From 002f7b81a14def4ce7f1d5ea100825f0b8ebc464 Mon Sep 17 00:00:00 2001 From: Ben Klein Date: Wed, 11 Jul 2018 16:19:52 -0400 Subject: [PATCH 1/2] Replace [[-v with `defined` For zsh 5.1 compatibility. --- powerlevel9k.zsh-theme | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/powerlevel9k.zsh-theme b/powerlevel9k.zsh-theme index c1ea754f..f1db3da1 100755 --- a/powerlevel9k.zsh-theme +++ b/powerlevel9k.zsh-theme @@ -498,7 +498,7 @@ prompt_battery() { fi fi # return if POWERLEVEL9K_BATTERY_HIDE_ABOVE_THRESHOLD is set and the battery percentage is greater or equal - if [[ -v "POWERLEVEL9K_BATTERY_HIDE_ABOVE_THRESHOLD" && "${bat_percent}" -ge $POWERLEVEL9K_BATTERY_HIDE_ABOVE_THRESHOLD ]]; then + if defined POWERLEVEL9K_BATTERY_HIDE_ABOVE_THRESHOLD && [[ "${bat_percent}" -ge $POWERLEVEL9K_BATTERY_HIDE_ABOVE_THRESHOLD ]]; then return fi From 45b0d68ec435a89ccc13193149a5bc306d449d04 Mon Sep 17 00:00:00 2001 From: Ben Klein Date: Thu, 12 Jul 2018 14:34:56 -0400 Subject: [PATCH 2/2] Replace `typeset` check with shellvar flag More performance without changing functionality. --- functions/utilities.zsh | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/functions/utilities.zsh b/functions/utilities.zsh index 69fd2ec8..127007fb 100755 --- a/functions/utilities.zsh +++ b/functions/utilities.zsh @@ -9,9 +9,7 @@ # Exits with 0 if a variable has been previously defined (even if empty) # Takes the name of a variable that should be checked. function defined() { - local varname="$1" - - typeset -p "$varname" > /dev/null 2>&1 + [[ ! -z "${(tP)1}" ]] } # Given the name of a variable and a default value, sets the variable