From 72991dd9e7fb465e53981f076ec5e44bc4f3bbb3 Mon Sep 17 00:00:00 2001 From: Dominik Ritter Date: Tue, 5 Mar 2019 21:57:37 +0100 Subject: [PATCH 1/5] Improve code style --- .github/ISSUE_TEMPLATE.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 01fbc413..8f6b3164 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -14,11 +14,11 @@ Most issues are best explained with a screenshot. Please share one if you can! #### Have you tried to debug or fix it? - Have you tinkered with your settings, and what happened when you did? Did you find a bit of code that you think might be the culprit? Let us know what you've done so far! #### Environment Information -This information will help us understand your configuration. + +This information will help us understand your configuration. - What version of ZSH are you using? You can use `zsh --version` to see this. - Do you use a ZSH framework (e.g., Oh-My-ZSH, Antigen)? From e5990572a34a767f321187ffc070ba34027a0d63 Mon Sep 17 00:00:00 2001 From: Dominik Ritter Date: Tue, 5 Mar 2019 22:30:30 +0100 Subject: [PATCH 2/5] Improve code style --- .github/PULL_REQUEST_TEMPLATE.md | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 4ade8059..76b1fac9 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -14,19 +14,20 @@ Once you have submitted your PR, P9k core contributors will review the code and Please follow this template for creating your PR: #### Title + Please make the title of your PR descriptive! If appropriate, please prefix the title with one of these tags: - - [Bugfix] - - [New Segment] - - [Docs] - - [Enhancement] - +- [Bugfix] +- [New Segment] +- [Docs] +- [Enhancement] + #### Description + Please describe the contribution your PR makes! Screenshots are especially helpful, here, if it's a new segment. If your PR is addressing an issue, please reference the Issue number here. #### Questions -Is there something in your PR you're not sure about or need help with? Is there a particular piece of code you would like feedback on? Let us know here! - +Is there something in your PR you're not sure about or need help with? Is there a particular piece of code you would like feedback on? Let us know here! From 6bf7498b544115cfa67330e6a03b371261872f21 Mon Sep 17 00:00:00 2001 From: Dominik Ritter Date: Tue, 5 Mar 2019 22:52:48 +0100 Subject: [PATCH 3/5] Add Performance Issue Template --- .../{ => ISSUE_TEMPLATE}/ISSUE_TEMPLATE.md | 9 +++++ .../PERFORMANCE_ISSUE_TEMPLATE.md | 38 +++++++++++++++++++ 2 files changed, 47 insertions(+) rename .github/{ => ISSUE_TEMPLATE}/ISSUE_TEMPLATE.md (95%) create mode 100644 .github/ISSUE_TEMPLATE/PERFORMANCE_ISSUE_TEMPLATE.md diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE/ISSUE_TEMPLATE.md similarity index 95% rename from .github/ISSUE_TEMPLATE.md rename to .github/ISSUE_TEMPLATE/ISSUE_TEMPLATE.md index 8f6b3164..5070d714 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE/ISSUE_TEMPLATE.md @@ -1,3 +1,12 @@ +--- +name: Bug report +about: Create a report to help us improve +title: '' +labels: '' +assignees: '' + +--- + Thanks for opening an issue! For a project that deals with as many different things as P9k, debugging problems can be difficult. Please follow the guide, below, to create a bug report that will help us help you! ### Before Opening a Bug diff --git a/.github/ISSUE_TEMPLATE/PERFORMANCE_ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE/PERFORMANCE_ISSUE_TEMPLATE.md new file mode 100644 index 00000000..9d852db0 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/PERFORMANCE_ISSUE_TEMPLATE.md @@ -0,0 +1,38 @@ +--- +name: Performance Issue +about: For performance Issues +title: "[Performance]" +labels: performance +assignees: '' + +--- + +Sorry to hear that the performance of P9K is not adequate. To fix this, please provide us with some hints. + +### Your Hardware + +Disk I/O is critical for P9K, so do you use a spinning disk, or a SSD? + +### Virtualization + +Do you use P9K in some sort of virtualization? This is also the case, if you use WSL on Windows.. + +### How Fast is Fast + +Could you quantify how fast the specific segment is, that you think is slow? +For example, if you think the `vcs` segment is slow, could you execute this command in the directory, where the segment is slow: + +```zsh +time (repeat 10; do; prompt_vcs left 1 false >/dev/null; done;) +``` + +Also, please provide us with some context around the segment. In the `vcs` example: + +- How big is the repo? +- Does it contain a lot of untracked files? +- Does it contain a lot of git submodules? +- Does it contain a lot of files in general? + +Additionally, you could install [zsh-prompt-benchmark](https://github.com/romkatv/zsh-prompt-benchmark), to benchmark the general performance of ZSH and P9K. + +If you don't know which segment is slow, could you remove one by one, and spot the one that made the greatest impact? \ No newline at end of file From a1747327fed78c1b9122643b635cf8b914b8b427 Mon Sep 17 00:00:00 2001 From: Dominik Ritter Date: Wed, 6 Mar 2019 00:19:58 +0100 Subject: [PATCH 4/5] Add changelog for v0.6.7 --- CHANGELOG.md | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index b40ce50b..271ae9ed 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,29 @@ +## v0.6.7 + +- PR #1175 - Fix home dir shortening when using package_name truncation strategy +- PR #1158 - [Bugfix] dir: Fix package name path truncation inside home dir +- PR #1157 - Hide stderr from git ls-files +- PR #1154 - Fix issues with debug/fonts script in Konsole +- PR #1151 - [Bugfix] Only abbreviate $HOME at the beginning of cwd +- PR #1148 - Remove checking for NODEENV_DISABLE_PROMPT +- PR #1147 - Fix newlines in ZSH 5.7 +- PR #1149 - Fix RVM +- PR #1128 - [Bugfix] virtualenv prompt displaying +- PR #981 - [Bugfix] Fix for #974 +- PR #1126 - Use ip command for VPN segment +- PR #1079 - [Bugfix] Update VIRTUAL_ENV_DISABLE_PROMPT value +- PR #1080 - [Bugfix] Port #1071 to `master` (Fix fatal errors emitted by untracked file check in vcs.zsh) +- PR #1074 - Add vcs vulnerability tests master +- PR #1070 - [Docs] Uniformly apply inline code formatting in README +- PR #1065 - Protect locale +- PR #1048 - Speedup Improvements in `vcs` segment +- PR #1037 - Fix vpn_ip segment +- PR #1036 - Make truncate with package name work without setting shorten length +- PR #1020 - Fix context spec +- PR #990 - [Docs] Add forgotten backtick +- PR #981 - Avoid error if `/etc/os-release` does not exist +- PR #966 - [Bugfix] Fix icons cut off in RPROMPT segments + ## v0.6.6 - The `rbenv` segment is no longer a default segment in the LPROMPT. From 7554ae9d6784aaa46514930488e1ac80d0394d8f Mon Sep 17 00:00:00 2001 From: Nicolas Badoux Date: Fri, 8 Mar 2019 16:56:31 +0100 Subject: [PATCH 5/5] doc battery threshold --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index c440ef2f..b4e5fb2c 100644 --- a/README.md +++ b/README.md @@ -208,6 +208,7 @@ systems without a battery). It is supported on both OSX and Linux (note that it |`POWERLEVEL9K_BATTERY_LOW_THRESHOLD`|`10`|Threshold to consider battery level critical.| |`POWERLEVEL9K_BATTERY_LOW_COLOR`|`"red"`|Color to indicate critically low charge level.| |`POWERLEVEL9K_BATTERY_VERBOSE`|`true`|Display time remaining next to battery level.| +|`POWERLEVEL9K_BATTERY_HIDE_ABOVE_THRESHOLD`|`unset`|Threshold from which the battery segment should not be displayed.| Note that you can [modify the `_FOREGROUND` color](https://github.com/bhilburn/powerlevel9k/wiki/Stylizing-Your-Prompt#segment-color-customization)